Skip to content

Harden dogfooding diagnostic path redaction - #2741

Merged
Chris0Jeky merged 2 commits into
mainfrom
issue-1480/redaction-helper
Sep 6, 2026
Merged

Harden dogfooding diagnostic path redaction#2741
Chris0Jeky merged 2 commits into
mainfrom
issue-1480/redaction-helper

Conversation

@Chris0Jeky

Copy link
Copy Markdown
Owner

Summary

  • extract dogfooding diagnostic path redaction into a path-flavour-aware, record-safe helper
  • preserve home-relative output while handling POSIX case sensitivity, Windows drive/UNC roots, sibling prefixes, and home=/ correctly
  • add table-driven unittest coverage without importing or executing the snapshot command

Verification

  • red-first unittest run failed on the baseline because redact was not injectable for path-flavour fixtures
  • py -3 -m unittest scripts/dogfooding/test_dogfood_snapshot.py -v: 4 tests passed
  • py -3 scripts/dogfooding/dogfood-snapshot.py --help: passed
  • py -3 -m compileall -q scripts/dogfooding/dogfood-snapshot.py scripts/dogfooding/test_dogfood_snapshot.py: passed
  • git diff --check: passed

This is only the bounded redaction-helper row from #1480. Active-day definition, fixture classification, account attribution, and database precedence remain out of scope.

Refs #1480

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Fresh-context review record (coordinator, 2026-09-06; read-only Opus 5 reviewer over the diff against the merge base; route: the standing D-12 rule for Codex-session PRs — review, fix MEDIUM+ in-PR, merge, disposition comment).

VERDICT: SHIP (round 1). Traced by hand and sound: drive root, UNC root, sibling-prefix, case-fold only on Windows, home="/", relative paths; ntpath.abspath behaves on POSIX hosts so the Windows fixtures are host-independent. Fixed in-PR (round 2, coordinator commit d952d8598, unittest suite OK): MEDIUM-2 — the No such database exit message printed the raw --db/$TASKDECK_DOGFOOD_DB path (username, org name), the one line most likely to be pasted into an issue; it is now redacted. Recorded for #1480, not fixed: MEDIUM-1 — no CI job executes test_dogfood_snapshot.py (reusable-docs-governance.yml discovers only the agent_hooks and analysis suites); wiring it is a control-plane change left for the CI lane. LOW — a POSIX filename containing a literal backslash renders as a directory boundary (pre-existing).

@Chris0Jeky
Chris0Jeky merged commit 4b6dd5d into main Sep 6, 2026
35 checks passed
@github-project-automation github-project-automation Bot moved this from Pending to Done in Taskdeck Execution Sep 6, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-1480/redaction-helper branch September 6, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant